Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-line values #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support multi-line values #36

wants to merge 2 commits into from

Conversation

chrisjohnson
Copy link 

 INSERT INTO "audit_records" ("row_id", "column_id", "event_type", "user", "created_at", "transaction_id") VALUES (values-redacted) RETURNING "id"
INSERT INTO "audit_records" ("row_id", "column_id", "event_type", "user", "new_value", "created_at", "transaction_id") VALUES (40, 16118, 'value-redacted'HFEzuSwT9IhijckAuVW7Xg==
|1bLZ4PtCsuTzoQRGchX9Cw==
'value-redacted', 24646) RETURNING "id"
 INSERT INTO "audit_records" ("row_id", "column_id", "event_type", "user", "new_value", "created_at", "transaction_id") VALUES (values-redacted) RETURNING "id"
 INSERT INTO "audit_records" ("row_id", "column_id", "event_type", "user", "old_value", "created_at", "transaction_id") VALUES (values-redacted) RETURNING "id"
 INSERT INTO "audit_records" ("row_id", "column_id", "event_type", "user", "old_value", "new_value", "created_at", "transaction_id") VALUES (values-redacted) RETURNING "id"

Handle this case correctly ^

@mikegee
Copy link
Contributor

mikegee commented Jun 24, 2019

Thanks for the contribution!

Would you kindly add a spec covering this case?

I can help you release a new version with this, if you need.

@chrisjohnson
Copy link
Author

@mikegee How's that? travis build is failing but that doesn't seem related to my PR but rather mismatched bundler version. The spec in question passes locally

@mikegee
Copy link
Contributor

mikegee commented Jun 25, 2019

Thanks for specifying the new behavior.

Are you comfortable tackling the CI failure in this PR too?

@chrisjohnson
Copy link
Author

It doesn't seem related to this PR at all, and frankly I'm not sure what the right approach here is. The test suite is running the tests in both ruby 2.3 and ruby 2.4, and complaining of a mis-matched bundler version. If you bump the bundler version you'll start passing in 2.4 and failing in 2.3 (currently passing in 2.3 but failing in 2.4). It seems like just removing one version or the other is appropriate? But I'm not really sure.

@AlexMooney AlexMooney mentioned this pull request Apr 23, 2020
Closed
davidmyersdev
davidmyersdev approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@davidmyersdev davidmyersdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the failing builds here would be fixed by #40.

This change looks good to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmyersdev davidmyersdev davidmyersdev approved these changes

@brandonjoyce brandonjoyce Awaiting requested review from brandonjoyce

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisjohnson @mikegee @davidmyersdev @cmm-cjohnson